Fixing a bug when MlFlow try to log a torch.tensor #29932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the case where a tensor with one element is log with Mlflow
Update integration_utils.py
amyeroberts
approved these changes
Mar 28, 2024
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
|
Sorry but what should I do to pass check_code_quality and setup_and_quality test ? this is my first PR |
|
@etiennebonnafoux Running |
4 tasks
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Update integration_utils.py Add the case where a tensor with one element is log with Mlflow * Update src/transformers/integrations/integration_utils.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * Update integration_utils.py add a whitespace --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* Update integration_utils.py Add the case where a tensor with one element is log with Mlflow * Update src/transformers/integrations/integration_utils.py Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * Update integration_utils.py add a whitespace --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the case where a torch.tensor with one element is log on Mlflow. For now it only accept float and int.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
Here Trainer is attempting to log a torch.Tensor but MLflow's only accepts float. #29784
documentation guidelines, and
here are tips on formatting docstrings.
No need
No need (two lines of code)
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@amyeroberts