[bnb] Fix bug in _replace_with_bnb_linear
#29958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR fixes a bug in
_replace_with_bnb_linear
when we usemodules_to_not_convert
. Before this PR, we were skipping the conversion of some modules if their name starts with "model.layers.1" (e.g. "model.layers.10.self_attn.q_proj") in the case wheremodules_to_not_convert = ['model.layers.1']
.Fixes #29691