Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] make 2 tests device-agnostic #30008

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Apr 3, 2024

What does this PR do?

After Fix:

$ RUN_SLOW=1 TRANSFORMERS_TEST_DEVICE=xpu TRANSFORMERS_TEST_DEVICE_SPEC=spec.py pytest tests/test_modeling_utils.py::ModelUtilsTest::test_model_parallelism_gpt2 tests/models/blip_2/test_modeling_blip_2.py::Blip2ModelIntegrationTest::test_inference_t5_multi_accelerator
==================================================== test session starts =====================================================
platform linux -- Python 3.9.19, pytest-7.4.4, pluggy-1.4.0
rootdir: /soft/fanli/transformers
configfile: pyproject.toml
plugins: xdist-3.5.0, metadata-3.1.1, reportlog-0.4.0, anyio-4.2.0, excel-1.6.0, hypothesis-6.98.0, html-4.1.1, timeout-2.3.1, env-1.1.3
collected 2 items                                                                                                            

tests/test_modeling_utils.py .                                                                                         [ 50%]
tests/models/blip_2/test_modeling_blip_2.py .                                                                          [100%]
=============================================== 2 passed, 5 warnings in 11.19s ===============================================

Who can review?

@ArthurZucker

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contiued efforts!

@ArthurZucker
Copy link
Collaborator

It's still draft tho, should we merge?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@faaany faaany marked this pull request as ready for review April 7, 2024 01:43
@faaany
Copy link
Contributor Author

faaany commented Apr 7, 2024

Hi @ArthurZucker, thanks for the review! Yes, let's merge it.

@ArthurZucker ArthurZucker merged commit 1854637 into huggingface:main Apr 10, 2024
18 checks passed
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants