Refactor daily CI workflow #30012
Merged
Refactor daily CI workflow #30012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Apr 3, 2024
ydshieh
commented
Apr 3, 2024
ydshieh
commented
Apr 3, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Apr 5, 2024
Comment on lines
+1088
to
+1093
| # Remove some entries in `additional_files` if they are not concerned. | ||
| test_name = None | ||
| job_name = os.getenv("CI_TEST_JOB") | ||
| if job_name in job_to_test_map: | ||
| test_name = job_to_test_map[job_name] | ||
| additional_files = {k: v for k, v in additional_files.items() if k == test_name} |
There was a problem hiding this comment.
were we testing additional things in some jobs?
There was a problem hiding this comment.
No. That additional means the test jobs that are not the modeling test jobs: deepspeed, quantization, example, pipeline test jobs.
ydshieh
changed the title
|
Make final commit(s) to clean up the channels stuff - all channels are created and used in the new workflow file. Will merge once CircleCI is done |
ydshieh
changed the title
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
* separate jobs * separate jobs * use channel name directly instead of ID * use channel name directly instead of ID * use channel name directly instead of ID --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* separate jobs * separate jobs * use channel name directly instead of ID * use channel name directly instead of ID * use channel name directly instead of ID --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a re-work of #29197. The main difference is: in this new work, we
self-scheduled.yml)self-scheduled-caller.yml) as the caller to the above one (self-scheduled.yml)self-scheduled.ymlThe reasons of the re-work:
push-ci,amd-cix 2,nightly-ci,past-cietc)Once approved and merged, the same refactorization will be applied to other workflow files.
I have made sure it runs successfully as expected: https://github.com/huggingface/transformers/actions/runs/8524250043
(please don't look at the diagram - look the left side instead)