Add datasets.Dataset to Trainer's train_dataset and eval_dataset type hints #30077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
reviewed
Apr 8, 2024
|
Rebasing onto main should resolve the unrelated test errors |
ringohoffman
deleted the
add-datasets-dataset-to-trainer-dataset-type-hints
branch
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
… hints (#30077) * Add datasets.Dataset to Trainer's train_dataset and eval_dataset type hints * Add is_datasets_available check for importing datasets under TYPE_CHECKING guard https://github.com/huggingface/transformers/pull/30077/files#r1555939352
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
… hints (#30077) * Add datasets.Dataset to Trainer's train_dataset and eval_dataset type hints * Add is_datasets_available check for importing datasets under TYPE_CHECKING guard https://github.com/huggingface/transformers/pull/30077/files#r1555939352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
datasets.DatasettoTrainer's type hints fortrain_datasetandeval_dataset.It is supported and mentioned by name in the docstrings for these parameters, but is not hinted as an acceptable type. Currently, if you try to call
Trainerwith adatasets.Datasetfor one of these parameters, type hinters like pyright raise an error.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@amyeroberts
@muellerzr
@pacman100