Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] add require_bitsandbytes marker #30116

Merged
merged 3 commits into from
Apr 8, 2024
Merged

[tests] add require_bitsandbytes marker #30116

merged 3 commits into from
Apr 8, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Apr 8, 2024 •
edited
Loading

What does this PR do?

The below 2 tests fails because I haven't installed bitsandbytes in my environment:

FAILED tests/models/persimmon/test_modeling_persimmon.py::PersimmonIntegrationTest::test_model_8b_chat_greedy_generation - ImportError: Using `bitsandbytes` 8-bit quantization requires Accelerate: `pip install accelerate` and the latest version of bitsandbytes: `pip install -i https://pypi.org/simple/ bitsandbytes`
FAILED tests/models/persimmon/test_modeling_persimmon.py::PersimmonIntegrationTest::test_model_8b_chat_logits - ImportError: Using `bitsandbytes` 8-bit quantization requires Accelerate: `pip install accelerate` and the latest version of bitsandbytes: `pip install -i https://pypi.org/simple/ bitsandbytes`

But these 2 tests should be skipped instead of failed. This PR fixes this issue by adding the require_bitsandbytes marker.

Who can review?

@ArthurZucker

@faaany faaany changed the title [tests] add require_bitsandbytes marker [tests] fix failing tests and add require_bitsandbytes marker Apr 8, 2024
@faaany faaany changed the title [tests] fix failing tests and add require_bitsandbytes marker [tests] add require_bitsandbytes marker Apr 8, 2024
amyeroberts
amyeroberts approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit d16f0ab into huggingface:main Apr 8, 2024
17 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 12, 2024
@faaany @zucchini-nlp
[tests] add require_bitsandbytes marker (huggingface#30116)
df07799 
* add bnb flag

* move maker

* add accelerator maker
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
@faaany @ArthurZucker
[tests] add require_bitsandbytes marker (#30116)
45393d1 
* add bnb flag

* move maker

* add accelerator maker
itazap pushed a commit that referenced this pull request May 14, 2024
@faaany
[tests] add require_bitsandbytes marker (#30116)
3293329 
* add bnb flag

* move maker

* add accelerator maker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faaany @amyeroberts