Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated examples/pytorch/language-modeling scripts and requirements.txt to require datasets>=2.14.0 #30120

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Patchwork53
Copy link
Contributor

What does this PR do?

All examples/pytorch/language-modeling scripts pass token argument to load_datasets(). The token argument was introduced in datasets==2.14.0, replacing use_auth_tokens. I updated the scripts and the requirements.txt to require datasets>=2.14.0

In response to my issue #30097

Who can review?

@ArthurZucker @amyeroberts

…rch/language-modeling to require datasets>=2.14.0
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix so quickly!

@amyeroberts amyeroberts merged commit 5e673ed into huggingface:main Apr 8, 2024
7 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 12, 2024
…xt to require datasets>=2.14.0 (huggingface#30120)

updated requirements.txt and require_version() calls in examples/pytorch/language-modeling to require datasets>=2.14.0
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
…xt to require datasets>=2.14.0 (#30120)

updated requirements.txt and require_version() calls in examples/pytorch/language-modeling to require datasets>=2.14.0
itazap pushed a commit that referenced this pull request May 14, 2024
…xt to require datasets>=2.14.0 (#30120)

updated requirements.txt and require_version() calls in examples/pytorch/language-modeling to require datasets>=2.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants