Revert workaround for TF safetensors loading #30128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
After testing on the PR branch, this looked good, so I merged the changes to |
|
All the actual tests are passing, but we have some rate limit errors on other tests. Raised the issue internally! |
amyeroberts
approved these changes
Apr 9, 2024
|
Merging as the failing tests are unrelated |
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
* See if we can get tests to pass with the fixed weights * See if we can get tests to pass with the fixed weights * Replace the revisions now that we don't need them anymore
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* See if we can get tests to pass with the fixed weights * See if we can get tests to pass with the fixed weights * Replace the revisions now that we don't need them anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30118 @amyeroberts skipped safetensors loading on TF models. I believe I've worked out the cause, and it was that the safetensors weights in that repo were a bit malformed. I tried fixing them by loading and saving them again with a torch
AutoModelForCausalLM, so hopefully we can use the fixed weights and revert the changes.