Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing annotation in hf_argparser #30156

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

xu-song
Copy link
Contributor

@xu-song xu-song commented Apr 10, 2024

What does this PR do?

Fix typing annotation in hf_argparser.

The following code raise warning in IDE: Expected type 'str', got 'Path' instead

parsed_args = parser.parse_yaml_file(Path(temp_local_path + ".json"))[0]

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Library:

Documentation: @stevhliu and @MKhalusova

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit 33bca54 into huggingface:main Apr 10, 2024
20 checks passed
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants