-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out kwargs in processor #30193
Merged
amyeroberts
merged 2 commits into
huggingface:main
from
amyeroberts:separate-clip-processor
Apr 15, 2024
Merged
Separate out kwargs in processor #30193
amyeroberts
merged 2 commits into
huggingface:main
from
amyeroberts:separate-clip-processor
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
reviewed
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much tidier, cool!
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Apr 18, 2024
* Separate out kwargs in processor * Fix up
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Separate out kwargs in processor * Fix up
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* Separate out kwargs in processor * Fix up
Eric2i
added a commit
to Eric2i/transformers
that referenced
this pull request
May 20, 2024
5 tasks
amyeroberts
pushed a commit
that referenced
this pull request
May 20, 2024
itazap
pushed a commit
that referenced
this pull request
May 24, 2024
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jun 11, 2024
…ace#30905) * Fix similar bug in processor (related to huggingface#30193) * Reformat processing_git.py to comply with ruff formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Separates out the kwargs that are passed to the processor into tokenizer and image processor kwargs.
This solves two issues:
Fixes #30106
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.