Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out kwargs in processor #30193

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

Separates out the kwargs that are passed to the processor into tokenizer and image processor kwargs.

This solves two issues:

  • Removes warnings from validation checks that now happen in the image processor (nice proof they're working!)
  • Prevents passing kwargs which have a name clash between the two processing classes

Fixes #30106

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@amyeroberts amyeroberts requested a review from molbap April 11, 2024 17:03
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much tidier, cool!

@amyeroberts amyeroberts merged commit ec344b5 into huggingface:main Apr 15, 2024
18 checks passed
@amyeroberts amyeroberts deleted the separate-clip-processor branch April 15, 2024 11:36
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 18, 2024
* Separate out kwargs in processor

* Fix up
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
* Separate out kwargs in processor

* Fix up
itazap pushed a commit that referenced this pull request May 14, 2024
* Separate out kwargs in processor

* Fix up
Eric2i added a commit to Eric2i/transformers that referenced this pull request May 20, 2024
amyeroberts pushed a commit that referenced this pull request May 20, 2024
* Fix similar bug in processor (related to #30193)

* Reformat processing_git.py to comply with ruff formatting
itazap pushed a commit that referenced this pull request May 24, 2024
* Fix similar bug in processor (related to #30193)

* Reformat processing_git.py to comply with ruff formatting
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
…ace#30905)

* Fix similar bug in processor (related to huggingface#30193)

* Reformat processing_git.py to comply with ruff formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused or unrecognized kwargs: padding, max_length, truncation.
3 participants