Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replaced deprecated typing.Text with str #30230

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

@Sai-Suraj-27 Sai-Suraj-27 commented Apr 12, 2024

What does this PR do?

typing.Text is an alias for str, and only exists for Python 2 compatibility. As of Python 3.11, typing.Text is deprecated.
Use str instead.

For Reference:
https://docs.python.org/3/library/typing.html#typing.Text
https://docs.astral.sh/ruff/rules/typing-text-str-alias/

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit b3595cf into huggingface:main Apr 15, 2024
17 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 18, 2024
typing.Text is deprecated. Use str instead
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
typing.Text is deprecated. Use str instead
itazap pushed a commit that referenced this pull request May 14, 2024
typing.Text is deprecated. Use str instead
@Sai-Suraj-27 Sai-Suraj-27 deleted the fix_deprecated_Text branch July 10, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants