fix: Fixed type annotation for compatability with python 3.8
#30243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sai-Suraj-27 Running |
Thanks for the review @amyeroberts. I have updated the PR and all the checks are passing now. |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Apr 18, 2024
…ngface#30243) * Fixed type annotation for compatability with python 3.8 * Fixed unsorted imports.
ArthurZucker
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Fixed type annotation for compatability with python 3.8 * Fixed unsorted imports.
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* Fixed type annotation for compatability with python 3.8 * Fixed unsorted imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Using
list[...]instead ofList[...]without thefrom __future__ import annotationsimport will cause runtime errors on Python versions prior to 3.9. Since, we are supporting python versions from3.8, this needs to be fixed.I used the following
ruffcheck to catch these.For reference: https://peps.python.org/pep-0585/
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @amyeroberts