Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLIP - fix pt-tf equivalence test #30258

Merged

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

Fixes failing test on main after merge of #30253

Failing run: https://app.circleci.com/pipelines/github/huggingface/transformers/89639/workflows/5b9e1145-97cd-452c-b36f-be6780d11f87/jobs/1168209

RUN_PT_TF_CROSS_TESTS=1 pytest tests/models/blip/test_modeling_blip.py::BlipTextImageModelTest::test_pt_tf_model_equivalence run and confirmed to be passing with this change

@amyeroberts amyeroberts requested a review from ydshieh April 15, 2024 16:34
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts
Copy link
Collaborator Author

Merging as this resolves tests failing on main

@amyeroberts amyeroberts merged commit c63f158 into huggingface:main Apr 16, 2024
19 checks passed
@amyeroberts amyeroberts deleted the fix-blip-pt-tf-equivalence-check branch April 16, 2024 16:46
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 18, 2024
* BLIP - fix pt-tf equivalence test

* Update tests/models/blip/test_modeling_blip.py

* Update more model tests
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
* BLIP - fix pt-tf equivalence test

* Update tests/models/blip/test_modeling_blip.py

* Update more model tests
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
* BLIP - fix pt-tf equivalence test

* Update tests/models/blip/test_modeling_blip.py

* Update more model tests
itazap pushed a commit that referenced this pull request May 14, 2024
* BLIP - fix pt-tf equivalence test

* Update tests/models/blip/test_modeling_blip.py

* Update more model tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants