Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove pad token id in pipeline forward arguments #30285

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes #30181. Moves pad_token_id as kwarg only in generation pipeline.

@zucchini-nlp zucchini-nlp requested a review from gante April 17, 2024 08:01
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix!

@gante gante merged commit 7913214 into huggingface:main Apr 18, 2024
21 checks passed
zucchini-nlp added a commit to zucchini-nlp/transformers that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.39.3; ZeroShotClassificationPipeline broken.
4 participants