Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to tokenizers 0.19.0 #30289

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Upgrading to tokenizers 0.19.0 #30289

merged 4 commits into from
Apr 17, 2024

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Apr 17, 2024

What does this PR do?

  • Need to update add_prefix_space to prepend_scheme (both are fused in breaking change).
  • Contains required fix for some tiktoken tokenizers breaking BPE schema.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Narsil Narsil requested review from ArthurZucker and amyeroberts and removed request for ArthurZucker April 17, 2024 10:14
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling these updates for the new release!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's post a message on slack or wait until tomorrow to merge?

@ArthurZucker ArthurZucker merged commit 8e5f76f into main Apr 17, 2024
22 checks passed
@ArthurZucker ArthurZucker deleted the upgrade_tokenizers branch April 17, 2024 15:17
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Apr 18, 2024
* [DO NOT MERGE] Testing tokenizers 0.19.0rc0

* Accounting for the breaking change.

* Ruff.

* Upgrading to tokenizers `0.19` (new release with preprend_scheme fixed
and new surface for BPE tiktoken bug).
@amyeroberts amyeroberts mentioned this pull request Apr 18, 2024
4 tasks
ArthurZucker pushed a commit that referenced this pull request Apr 22, 2024
* [DO NOT MERGE] Testing tokenizers 0.19.0rc0

* Accounting for the breaking change.

* Ruff.

* Upgrading to tokenizers `0.19` (new release with preprend_scheme fixed
and new surface for BPE tiktoken bug).
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
* [DO NOT MERGE] Testing tokenizers 0.19.0rc0

* Accounting for the breaking change.

* Ruff.

* Upgrading to tokenizers `0.19` (new release with preprend_scheme fixed
and new surface for BPE tiktoken bug).
itazap pushed a commit that referenced this pull request May 14, 2024
* [DO NOT MERGE] Testing tokenizers 0.19.0rc0

* Accounting for the breaking change.

* Ruff.

* Upgrading to tokenizers `0.19` (new release with preprend_scheme fixed
and new surface for BPE tiktoken bug).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants