Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inhomogeneous shape error in example #30434

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix inhomogeneous shape error in example #30434

merged 1 commit into from
May 21, 2024

Conversation

Zantares
Copy link

What does this PR do?

Fixes #30000 , which has reported an inhomogeneous shape error in the QA example with numpy >= 1.24.0:

batch = {k: np.array(v) for k, v in batch.items()} ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 2 dimensions. The detected shape was (64, 384) + inhomogeneous part.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@sanchit-gandhi

@Zantares
Copy link
Author

@ArthurZucker can you help to review this PR? Thanks!

Copy link
Contributor

@sanchit-gandhi sanchit-gandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, and thanks for the clean fix @Zantares! Just one core maintainer review required from @amyeroberts, then we'll get this PR merged!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts amyeroberts merged commit 5bf9caa into huggingface:main May 21, 2024
7 checks passed
@Zantares Zantares deleted the tenglu/fix_example_shape branch May 22, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running flax run_qa.py got errors after upgrading dependencies software
3 participants