-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEFT / Trainer: Make use of model.active_adapters()
instead of deprecated model.active_adapter
whenever possible
#30738
PEFT / Trainer: Make use of model.active_adapters()
instead of deprecated model.active_adapter
whenever possible
#30738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this in a backwards compatible way.
Do we plan to one day require a min PEFT version that would make this extra check unnecessary? If yes, we could add a # TODO
comment to the code that can be removed.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling the deprecation!
As per title and as mentioned offline by @BenjaminBossan,
model.active_adapter
will be deprecated soon, let's make sure to slowly force Trainer to fallback intomodel.active_adapters
insteadcc @BenjaminBossan @amyeroberts