-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST / Workflows: Get slack notifications for docker image build #30891
Conversation
if: always() | ||
uses: huggingface/hf-workflows/.github/actions/post-slack@main | ||
with: | ||
slack_channel: "C073ZTN10A1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to correct env name in the future and use a secret
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea ! Thx for adding this !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
It sends many separate reports for a workflow run however. Ideally it might be a good idea to send all of these in on go (in a final job), but it will require some changes in hf-workflows
. So I wouldn't insist such change in this PR.
Thanks so much for the review @ydshieh ! |
…ingface#30891) * Get slack notifications for docker image build * Apply suggestions from code review * Apply suggestions from code review
* Get slack notifications for docker image build * Apply suggestions from code review * Apply suggestions from code review
* Get slack notifications for docker image build * Apply suggestions from code review * Apply suggestions from code review
…ingface#30891) * Get slack notifications for docker image build * Apply suggestions from code review * Apply suggestions from code review
What does this PR do?
As per title, as similarly as huggingface/peft#1723 - I created a new slack channel to receive notifications on the docker image build status for all our docker images
We do that in PEFT / diffusers (huggingface/diffusers#7938)
Related to: #30890
cc @ydshieh