Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeepSpeed compatibility with weight_norm (#30881) #31018

Merged
merged 1 commit into from
May 28, 2024

Conversation

jonnyli1125
Copy link
Contributor

@jonnyli1125 jonnyli1125 commented May 24, 2024

What does this PR do?

Fixes #30881

As described in the PyTorch docs, torch.nn.utils.weight_norm is deprecated in favour of torch.nn.utils.parametrizations.weight_norm, which renames the attributes weight_g and weight_v to parametrizations.weight.original0 and parametrizations.weight.original1 respectively.

This MR fixes a bug where when loading certain models with DeepSpeed ZeRO-3, the old attribute names were still being used, causing an AttributeError. The attribute names have been updated to the new ones if they are available.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ylacombe @sanchit-gandhi @pacman100

@amyeroberts
Copy link
Collaborator

cc @SunMarc @muellerzr

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing !

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@amyeroberts amyeroberts merged commit 476890e into huggingface:main May 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wav2vec2 model has unknown attributes weight_g/weight_v when DeepSpeed ZeRO-3 is enabled
5 participants