Fix DeepSpeed compatibility with weight_norm (#30881) #31018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #30881
As described in the PyTorch docs, torch.nn.utils.weight_norm is deprecated in favour of torch.nn.utils.parametrizations.weight_norm, which renames the attributes
weight_g
andweight_v
toparametrizations.weight.original0
andparametrizations.weight.original1
respectively.This MR fixes a bug where when loading certain models with DeepSpeed ZeRO-3, the old attribute names were still being used, causing an AttributeError. The attribute names have been updated to the new ones if they are available.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ylacombe @sanchit-gandhi @pacman100