Make "tool_use" the default chat template key when tools are passed #31429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Jun 14, 2024
|
Will do! |
Rocketknight1
force-pushed
the
update_chat_template_default
branch
from
5c43cd7 to
415a08e
Compare
|
@amyeroberts I added some opinionated text where I explain this and try to dissuade people from writing templates this way (I might eventually chase down the cases where people are doing it and ban it as a feature, we'll see!) |
itazap
pushed a commit
that referenced
this pull request
Jun 18, 2024
…31429) * Make "tool_use" the default when tools are passed * Add some opinionated text to the docs * Add some opinionated text to the docs
itazap
pushed a commit
that referenced
this pull request
Jun 20, 2024
…31429) * Make "tool_use" the default when tools are passed * Add some opinionated text to the docs * Add some opinionated text to the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've started to see models with multiple templates, keyed by name. The standard name (or at least the standard I'm trying to enforce) is that the template for tool use is called
tool_use.This PR updates the chat template logic so that if there's a template named "tool_use" and the user has passed tools, then that template will be used as the default.