Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug about add_special_tokens and so on #31496

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fix bug about add_special_tokens and so on #31496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e09237
fix bug about add_special_tokens and so on
hiroshi-matsuda-rit Jun 19, 2024
66be0f8
improve add_special_tokens and padding behavior
hiroshi-matsuda-rit Jun 20, 2024
3e99660
add a test case for add_special_tokens and padding
hiroshi-matsuda-rit Jun 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/transformers/pipelines/text_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,10 @@ def _sanitize_parameters(

add_special_tokens = False
if "add_special_tokens" in generate_kwargs:
preprocess_params["add_special_tokens"] = generate_kwargs["add_special_tokens"]
add_special_tokens = generate_kwargs["add_special_tokens"]
add_special_tokens = preprocess_params["add_special_tokens"] = generate_kwargs.pop("add_special_tokens")

if "padding" in generate_kwargs:
preprocess_params["padding"] = generate_kwargs["padding"]
preprocess_params["padding"] = generate_kwargs.pop("padding")

if truncation is not None:
preprocess_params["truncation"] = truncation
Expand Down
14 changes: 14 additions & 0 deletions tests/pipelines/test_pipelines_text_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,20 @@ def test_small_model_pt(self):
)
assert output_str != output_str_with_truncation # results must be different because one had truncation

## -- test kwargs for preprocess_params
outputs = text_generator("This is a test", do_sample=False, add_special_tokens=False, padding=False)
self.assertEqual(
outputs,
[
{
"generated_text": (
"This is a test ☃ ☃ segmental segmental segmental 议议eski eski flutter flutter Lacy oscope."
" oscope. FiliFili@@"
)
}
],
)

# -- what is the point of this test? padding is hardcoded False in the pipeline anyway
text_generator.tokenizer.pad_token_id = text_generator.model.config.eos_token_id
text_generator.tokenizer.pad_token = "<pad>"
Expand Down