Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move translations to i18n #31584

Merged
merged 1 commit into from
Jun 26, 2024
Merged

docs: move translations to i18n #31584

merged 1 commit into from
Jun 26, 2024

Conversation

SauravMaheshkar
Copy link
Contributor

What does this PR do?

Fixes #31542

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Request for Review: @stevhliu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the README.md translations to their own separate folder, LGTM! The main repo should look cleaner now :)

Pinging @amyeroberts @LysandreJik for a quick look before we merge.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for handling!

Agreed, let's double check with @LysandreJik here re the structural change

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@LysandreJik LysandreJik merged commit 2daf2c3 into huggingface:main Jun 26, 2024
8 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/i18n branch June 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gh: consider i18n
5 participants