[HybridCache] Fix get_seq_length method
#31661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchit-gandhi
force-pushed
the
gemma-2-path
branch
from
28a8eff to
b94f46d
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Failures seem unrelated; I'll merge it and do a patch release |
LysandreJik
pushed a commit
that referenced
this pull request
Jun 27, 2024
* fix gemma2 * handle in generate
|
Patch is up on pypi! Thanks both for the quick PR and review :) |
xianbaoqian
added a commit
to huggingface/blog
that referenced
this pull request
Jun 28, 2024
Update the transformers version to fix Gemma support issue. Context: huggingface/transformers#31661
philschmid
pushed a commit
to huggingface/blog
that referenced
this pull request
Jun 28, 2024
* Update gemma2.md Update the transformers version to fix Gemma support issue. Context: huggingface/transformers#31661 * Update gemma2.md
|
Thanks @LysandreJik for the speedy patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #31664