Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gguf conversion add_prefix_space=None for llama3 #31937

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

itazap
Copy link
Collaborator

@itazap itazap commented Jul 12, 2024

fixes #31630

gguf conversion forces add_prefix_space=False for llama3, this is not required and forces from_slow, which fails. changing to None + test

@ArthurZucker

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's fix tests and merge

itazap added 3 commits July 23, 2024 10:58
… required and forces from_slow, which fails. changing to None + test
@itazap itazap marked this pull request as ready for review July 23, 2024 08:59
@itazap itazap force-pushed the guff_prefix_space_llama3 branch from 8f394a4 to d149907 Compare July 23, 2024 08:59
@itazap itazap merged commit a1844a3 into main Jul 23, 2024
22 checks passed
@itazap itazap deleted the guff_prefix_space_llama3 branch July 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The behavior of the tokenizer loaded from GGUF file is incorrect.
4 participants