Masking: remove flakiness from test #31939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know how different they are? Could we check with a tolerance instead? I'm find removing the hard check, but the two outputs being similar seems like a good thing to make sure we're keeping |
|
@amyeroberts that check already exists 🙌 (expand the diff) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 16, 2024
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jul 19, 2024
MHRDYN7
pushed a commit
to MHRDYN7/transformers
that referenced
this pull request
Jul 23, 2024
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 24, 2024
itazap
pushed a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test_custom_4d_attention_maskwas trying to compare the argmax of two sets of logits. The logits should be the same in theory -- one is created through batched inference, the other through properly masked and stacked inputs.We know from experience that batching introduces tiny fluctuations -- see this comment explaining why.
As such, the argmax of these two tensors can have different values, resulting in a flaky test. This PR removes the flaky part of the test, the equality check of the argmax. We still check that the two tensors are very similar.
Example of a failing test due to flakiness: https://app.circleci.com/pipelines/github/huggingface/transformers/97709/workflows/f407565a-dd9f-423f-9af2-86f0925cf109/jobs/1294534