Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mistral] Fix FA2 attention reshape for Mistral Nemo #32065

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

xenova
Copy link
Contributor

@xenova xenova commented Jul 18, 2024

What does this PR do?

Follow-up to #32050. Fixes https://huggingface.co/mistralai/Mistral-Nemo-Instruct-2407/discussions/6

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

@xenova xenova changed the title [mistral] Fix FA2 attention reshape [mistral] Fix FA2 attention reshape for Mistral Nemo Jul 18, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker merged commit 22f888b into main Jul 19, 2024
22 checks passed
@ArthurZucker ArthurZucker deleted the mistral-fix-fa2 branch July 19, 2024 09:19
CL-ModelCloud pushed a commit to CL-ModelCloud/transformers that referenced this pull request Jul 19, 2024
* [mistral] Fix FA2 attention reshape

* [run-slow] mistral
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants