🚨🚨🚨 Update min version of accelerate to 0.26.0 #32627
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Thanks!
LGTM - let's have @ydshieh confirm this is all that's necessary, I'm still a bit out of touch with the official process for updating the docker images
Oh that's true that we don't have any check for accelerate inside TrainingArguments. Is accelerate a required dep for using |
|
@SunMarc yes it is (the pytorch version). You can see some similar checks for |
Thanks ! This should be fixed in the latest commit. Also I removed a few checks that aren't needed anymore. |
| os.environ[f"{prefix}SHARDING_STRATEGY"] = str( | ||
| FSDP_SHARDING_STRATEGY.index(fsdp_option.upper()) + 1 |
There was a problem hiding this comment.
Nit: I can't wait until these hacks aren't needed anymore :)
|
Failing tests are not related to my PR. See the linked PR above. Other than that, tests are passing ! I'll wait until @ydshieh approves to merge this PR ! |
|
Failures are indeed unrelated, you can rebase on #32649 to skip tests that are currently failing and it should work (or wait till it's merged on main) |
The daily CI is using the most recent version of accelerate, so that should be fine ! |
* Update min version of accelerate to 0.26.0 * dev-ci * update min version in import * remove useless check * dev-ci * style * dev-ci * dev-ci
What does this PR do ?
This PR updates the minimum version required for accelerate to
0.26.0.Fixes #31449
Creating a dev docker, waiting for the tests to pass.