Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate coverage cfg to pyproject.toml #32650

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: migrate coverage cfg to pyproject.toml #32650

merged 1 commit into from
Sep 17, 2024

Conversation

SauravMaheshkar
Copy link
Contributor

What does this PR do?

Migrate coverage configuration to pyproject.toml

Before submitting

@amyeroberts
Copy link
Collaborator

cc @ydshieh

@ydshieh
Copy link
Collaborator

ydshieh commented Aug 22, 2024

Hi @SauravMaheshkar Could you elaborate this a bit more? For example, where we can find the output coverage report file?

@SauravMaheshkar
Copy link
Contributor Author

There should be no difference in where the output file is generated. It's just a simple change of where coverage is configured.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 16, 2024

For the record:

https://coverage.readthedocs.io/en/latest/config.html

Coverage.py will read from “pyproject.toml” if TOML support is available, either because you are running on Python 3.11 or later, or because you installed with the toml extra (pip install coverage[toml]

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit 642256d into huggingface:main Sep 17, 2024
7 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/refactor-coverage-config branch September 17, 2024 11:53
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants