Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jamba cache fails to use torch.nn.module #32894

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

xgal
Copy link
Contributor

@xgal xgal commented Aug 20, 2024

Fixes # 32853

What does this PR do?

Fix for issue: #32853
AttributeError: 'HybridMambaAttentionDynamicCache' object has no attribute '_modules'

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts
Copy link
Collaborator

cc @ArthurZucker @gante

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix

@ArthurZucker ArthurZucker merged commit 01c4fc4 into huggingface:main Aug 20, 2024
16 of 18 checks passed
Titus-von-Koeller pushed a commit to jiqing-feng/transformers that referenced this pull request Aug 21, 2024
ArthurZucker pushed a commit that referenced this pull request Aug 22, 2024
Co-authored-by: Gal Cohen <galc@ai21.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants