Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-ar] Translated file : docs/source/ar/notebooks.md into Arabic #33049

Merged

Conversation

AhmedAlmaghz
Copy link
Contributor

What does this PR do?

Translated the docs/source/ar/notebooks.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

Copy link
Contributor

@abodacs abodacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

السﻻم عليكم
https://huggingface.co/docs/transformers/main/en/notebooks
ليست هذا الترجمه للملف

@AhmedAlmaghz

@AhmedAlmaghz
Copy link
Contributor Author

Thank you @abodacs
Done update notebooks.md
Please, Review it again

@AhmedAlmaghz AhmedAlmaghz requested a review from abodacs November 29, 2024 04:20
@Rocketknight1
Copy link
Member

cc @stevhliu

@AhmedAlmaghz AhmedAlmaghz marked this pull request as ready for review December 2, 2024 06:10
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit 4955e4e into huggingface:main Dec 2, 2024
9 checks passed
@AhmedAlmaghz AhmedAlmaghz deleted the Add_docs_source_ar_notebooks.md branch December 3, 2024 01:11
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…huggingface#33049)

* Add docs/source/ar/notebooks.md to Add_docs_source_ar_notebooks.md

* Update notebooks.md

* Update _toctree.yml
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
…huggingface#33049)

* Add docs/source/ar/notebooks.md to Add_docs_source_ar_notebooks.md

* Update notebooks.md

* Update _toctree.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants