Bugfix/alexsherstinsky/fix none check for attention factor in rope scaling 2024 08 28 0 #33188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tention_factor_in_rope_scaling-2024_08_28-0
…tention_factor_in_rope_scaling-2024_08_28-0
…tention_factor_in_rope_scaling-2024_08_28-0
|
Hello, @LysandreJik and @ArthurZucker -- could you please help me with some guidance in terms of what I need to do in order to get this pull request reviewed (and merged, if approved)? Please feel free to make edits on my behalf. Thank you very much in advance for your time. |
|
Hey @alexsherstinsky, Arthur will review your PR as soon as he has a bit of bandwidth available! Sorry for the delay, the repo is particularly active right now. |
ArthurZucker
approved these changes
Sep 4, 2024
alexsherstinsky
deleted the
bugfix/alexsherstinsky/fix_none_check_for_attention_factor_in_rope_scaling-2024_08_28-0
branch
@LysandreJik Many thanks to you and @ArthurZucker for reviewing and merging -- your libraries are a treasure trove! |
|
🤗 thanks for your warm words |
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
…aling 2024 08 28 0 (huggingface#33188) * Fixing a bug in the way "attention_factor" is validated in ROPE utilities. * Fixing a bug in the way "attention_factor" is validated in ROPE utilities. * Fixing a bug in the way "attention_factor" is validated in ROPE utilities.
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…aling 2024 08 28 0 (huggingface#33188) * Fixing a bug in the way "attention_factor" is validated in ROPE utilities. * Fixing a bug in the way "attention_factor" is validated in ROPE utilities. * Fixing a bug in the way "attention_factor" is validated in ROPE utilities.
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
…aling 2024 08 28 0 (huggingface#33188) * Fixing a bug in the way "attention_factor" is validated in ROPE utilities. * Fixing a bug in the way "attention_factor" is validated in ROPE utilities. * Fixing a bug in the way "attention_factor" is validated in ROPE utilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
attention_factorcan raise"TypeError: '<' not supported between instances of 'NoneType' and 'int'"ifattention_factorisNone.tests/utils/test_modeling_rope_utils.py::RopeTest::test_longrope_rope_numericallyis extended to ensure that theconfigis validated and the above error is not raised.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.