Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix upper nltk version #33301

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

ylacombe
Copy link
Contributor

@ylacombe ylacombe commented Sep 4, 2024

What does this PR do?

NLTK recent 3.9 release breaks FastSpeechConformer2 tests on our CI.

More on this:

  • I've managed to pinpoint the precise commit
  • It could probably be solved by upgrading this snippet in g2P with averaged_perceptron_tagger -> averaged_perceptron_tagger_eng, but the library hasn't been updated in 5 years
  • Another way we could handle it is to manually run:
>>> import nltk
>>> nltk.download('averaged_perceptron_tagger_eng')

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's pin it. Thank you.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ylacombe ylacombe merged commit a1faf22 into huggingface:main Sep 4, 2024
22 checks passed
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants