Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve device issue in cos and sin in Qwen2's ROPE Embedding #33391

Closed

Conversation

irislin1006
Copy link

@irislin1006 irislin1006 commented Sep 9, 2024

What does this PR do?

This PR addresses a device mismatch issue in the apply_rotary_pos_emb function within the Qwen model implementation. Specifically, the cos and sin tensors, used for rope, were placed on the CPU, while other tensors (q, k, and position_ids) were on the GPU. This discrepancy caused a runtime error during training.

The fix ensures that cos and sin are moved to the same device as position_ids, resolving the inconsistency and allowing the model to run successfully on the GPU.

Fixes (#32312)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@irislin1006 irislin1006 changed the title solve device issue in cos ans sin solve device issue in cos and sin in Qwen2's ROPE Embedding Sep 9, 2024
@irislin1006
Copy link
Author

Will close this draft. Given the topic for this PR is solved by: The problem was fixed in this PR: huggingface/transformers#32617.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant