Fix: Cast prefetch_bucket_size to integer for deepspeed >= 0.15 #33402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
approved these changes
Sep 10, 2024
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
…ingface#33402) Fix: Cast prefetch bucket size to integer in zero_optimization
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
…ingface#33402) Fix: Cast prefetch bucket size to integer in zero_optimization
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…ingface#33402) Fix: Cast prefetch bucket size to integer in zero_optimization
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
…ingface#33402) Fix: Cast prefetch bucket size to integer in zero_optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix compatibility with deepspeed versions >= 0.15
Deepspeed >= 0.15 integration fails due to a validation error where
stage3_prefetch_bucket_sizeexpects an integer but receives a float.Ensure
prefetch_bucket_sizeis always passed as an integer to avoid errors when using deepspeed. This change resolves compatibility issues with deepspeed versions 0.15 and above.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr