-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the wandb logging issue #33464
fix the wandb logging issue #33464
Conversation
Duplicate of #33440? |
ooooh same issue. the implementation difference is that |
Is it guaranteed that we have access to the wandb pkg in the file? If so, I'd also appreciate your variant of doing it by top-level import. Maybe you can help out with the other PR so that we can concentrate our focus on one :) |
Ohh whoops, ig the import can't be seen in Guess it has to be moved into transformers/src/transformers/integrations/integration_utils.py Lines 804 to 806 in bbef91a
So based on self._initialized / after passing the first check that wandb is not None, it would be safe to import then.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There are a few code quality issues as @vasqu mentions above and can be seen in the code quality check; please fix those and I'll merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
* fix the wandb logging issue * handle ConfigError in WandbCallback; move import to local scope * update integration_utils.py; move import of ConfigError * Update integration_utils.py: remove trailing whitespace
* fix the wandb logging issue * handle ConfigError in WandbCallback; move import to local scope * update integration_utils.py; move import of ConfigError * Update integration_utils.py: remove trailing whitespace
* fix the wandb logging issue * handle ConfigError in WandbCallback; move import to local scope * update integration_utils.py; move import of ConfigError * Update integration_utils.py: remove trailing whitespace
* fix the wandb logging issue * handle ConfigError in WandbCallback; move import to local scope * update integration_utils.py; move import of ConfigError * Update integration_utils.py: remove trailing whitespace
What does this PR do?
Fixes #33320.
The existing error handling for wandb misses
ConfigError
when attempting to change the number of parameters, thus still blocking training; just addedConfigError
to fix.