-
Notifications
You must be signed in to change notification settings - Fork 27.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Trainer's liger-kernel integration to call correct patching API #33502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimizust
force-pushed
the
sshimizu/liger-fix
branch
from
September 16, 2024 17:42
41842cb
to
26ea9e2
Compare
LGTM thanks for the great work! |
qingquansong
approved these changes
Sep 16, 2024
SunMarc
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for updating the API !
ArthurZucker
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating, in time for the next release that will include both
itazap
pushed a commit
to NielsRogge/transformers
that referenced
this pull request
Sep 20, 2024
…PI (huggingface#33502) * Updated liger-kernel integration in Trainer to call correct patching API * Fixed styling
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Oct 2, 2024
…PI (huggingface#33502) * Updated liger-kernel integration in Trainer to call correct patching API * Fixed styling
4 tasks
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…PI (huggingface#33502) * Updated liger-kernel integration in Trainer to call correct patching API * Fixed styling
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
…PI (huggingface#33502) * Updated liger-kernel integration in Trainer to call correct patching API * Fixed styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
use_liger_kernel
flag to apply liger kernels to the given model based on model type (Integrate Liger (Linkedin GPU Efficient Runtime) Kernel to Trainer #32860). However, we realized that calling patching APIs after the model has been initialized will only partially patch with Liger kernels (see https://github.com/linkedin/Liger-Kernel/pull/199/files for more details).Testing
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
cc @SunMarc @ArthurZucker