Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests in ASR pipeline #33545

Merged

Conversation

ylacombe
Copy link
Contributor

What does this PR do?

#33509 highlighted that some slow ASR tests were never passing, due to how data was loaded. This PR mainly fixes this + fixes some slow Whisper tests that are easy to fix.

There's still 3 slow failing tests in the ASR pipeline related to Whisper, but they'll have to wait for other Whisper fixes.

Remaining failing tests

FAILED tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_simple_whisper_asr - AssertionError: {'tex[827 chars]4.56, 4.92)}, {'text': ' gospel.', 'timestamp': (4.92, 5.82)}]} != {'tex[827 chars]4.56, 4.92)}, {'text': ' gospel.', 'timestamp': (4.92, 5.84)}]}
FAILED tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_simple_whisper_translation - AssertionError: {'text': ' A man said to the universe, Sir, I exist.'} != {'text': ' Mr. Quilter is the apostle of the middle [43 chars]el.'}
FAILED tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_whisper_word_timestamps_batched - AssertionError: {'tex[81 chars] his to welcome his gospel.', 'chunks': [{'tex[898 chars]2)}]} != {'tex[81 chars] his gospel.', 'chunks': [{'text': ' Mr.', 'ti[747 chars]2)}]}

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the tests!

@ylacombe ylacombe merged commit f883827 into huggingface:main Sep 18, 2024
18 checks passed
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants