Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] make more tests device-agnostic #33580

Merged
merged 12 commits into from
Sep 20, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Sep 19, 2024

What does this PR do?

This PR makes some cuda-only tests device-agnostic. There are still some tests fail on XPU due to numerical precision issue, but in general all of them should apply to other hardware accelerators besides cuda.

@amyeroberts

@faaany faaany marked this pull request as ready for review September 20, 2024 01:24
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for all your work making our tests device agnostic!

@amyeroberts amyeroberts merged commit 8bd1f2f into huggingface:main Sep 20, 2024
15 checks passed
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
* enable

* fix

* add xpu skip

* add marker

* skip for xpu

* add more

* enable on accelerator

* add more cases

* add more tests

* add more
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
* enable

* fix

* add xpu skip

* add marker

* skip for xpu

* add more

* enable on accelerator

* add more cases

* add more tests

* add more
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* enable

* fix

* add xpu skip

* add marker

* skip for xpu

* add more

* enable on accelerator

* add more cases

* add more tests

* add more
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* enable

* fix

* add xpu skip

* add marker

* skip for xpu

* add more

* enable on accelerator

* add more cases

* add more tests

* add more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants