Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdpa for BioGpt #33592

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Add sdpa for BioGpt #33592

merged 6 commits into from
Sep 20, 2024

Conversation

OmarManzoor
Copy link
Contributor

What does this PR do?

Towards #28005

Adds sdpa for the Bio GPT model.

Who can review?

@amyeroberts

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean ❤️ Thanks for adding this and running all the speed and mem comparisons too!

For the slow tests, they were skipped because the PR didn't have the run-slow label, which I've added now. Could you push another empty commit with the run slow message to retrigger these?

cc @Rocketknight1 for reference

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM too! Thank you for the PR!

@amyeroberts amyeroberts merged commit 653eb40 into huggingface:main Sep 20, 2024
17 checks passed
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
* Add sdpa for BioGpt

* Updates

* Add the docs

* [run_slow] biogpt

* Use the copy mechanism to ensure consistency

* [run_slow] biogpt
@OmarManzoor OmarManzoor deleted the bio_gpt_sdpa branch September 26, 2024 10:18
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
* Add sdpa for BioGpt

* Updates

* Add the docs

* [run_slow] biogpt

* Use the copy mechanism to ensure consistency

* [run_slow] biogpt
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* Add sdpa for BioGpt

* Updates

* Add the docs

* [run_slow] biogpt

* Use the copy mechanism to ensure consistency

* [run_slow] biogpt
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
* Add sdpa for BioGpt

* Updates

* Add the docs

* [run_slow] biogpt

* Use the copy mechanism to ensure consistency

* [run_slow] biogpt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants