Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add the ability to manually trigger jobs #33598

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

gante
Copy link
Member

@gante gante commented Sep 19, 2024

What does this PR do?

Our doc-builder had a bug that was fixed recently (huggingface/doc-builder#516). This bug has an impact on our docs since v4.41 -- we need to manually trigger the job to push the fixed docs.

This PR adds the ability to manually trigger the doc builder :)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@@ -1,6 +1,7 @@
name: Build documentation

on:
workflow_dispatch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is if ${{ github.sha }} (see below) will be the correct (previous) release tag commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Github doc here: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch

Last commit on the GITHUB_REF branch or tag

So I think it should work fine.

@gante gante merged commit bdf4649 into huggingface:main Sep 20, 2024
8 checks passed
@gante gante deleted the docs_workflow_dispatch branch September 20, 2024 08:37
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants