Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CPM model tests #33621

Merged

Conversation

amyeroberts
Copy link
Collaborator

@amyeroberts amyeroberts commented Sep 20, 2024

What does this PR do?

Noticed that the CPM tokenization test were running XLNet model tests, which are already run elsewhere, so removing this inheritance.

@amyeroberts amyeroberts requested a review from ydshieh September 20, 2024 12:01
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@amyeroberts amyeroberts changed the title Remove CPM model tests Remove unnecessary CPM model tests Sep 20, 2024
@amyeroberts amyeroberts merged commit f9b4409 into huggingface:main Sep 20, 2024
11 checks passed
@amyeroberts amyeroberts deleted the cpm-remove-unnecessary-model-tests branch September 20, 2024 13:21
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
amyeroberts added a commit to amyeroberts/transformers that referenced this pull request Oct 2, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants