Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 [i18n-KO] Translated model_doc/deberta-v2.md to Korean #33968

Merged
merged 5 commits into from
Oct 9, 2024
Merged

🌐 [i18n-KO] Translated model_doc/deberta-v2.md to Korean #33968

merged 5 commits into from
Oct 9, 2024

Conversation

fabxoe
Copy link
Contributor

@fabxoe fabxoe commented Oct 5, 2024 •
edited
Loading

What does this PR do?

Translated the model_doc/deberta-v2.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

@chhaewxn, @ahnjj, @jun048098, @fabxoe, @nuatmochoi, @heuristicwave

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@stevhliu May you please review this PR?

@fabxoe fabxoe changed the title 🌐 [i18n-KO] Translated model_doc/deberta-v2.md 🌐 [i18n-KO] Translated model_doc/deberta-v2.md to Korean Oct 5, 2024
chhaewxn
chhaewxn reviewed Oct 6, 2024
View reviewed changes
Copy link
Contributor

@chhaewxn chhaewxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단한 리뷰 남겨보았습니다! 좋은 번역 감사드립니다🤗

fabxoe and others added 2 commits October 6, 2024 19:52
@fabxoe @chhaewxn
fix: resolve suggestions
500f98e 
Co-authored-by: Chaewon Song <chaewon1019@ewhain.net>
@fabxoe
fix: resolve suggestions
02a1c50
@fabxoe fabxoe marked this pull request as ready for review October 7, 2024 02:20
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevhliu stevhliu merged commit db5f117 into huggingface:main Oct 9, 2024
8 checks passed
NielsRogge pushed a commit to NielsRogge/transformers that referenced this pull request Oct 21, 2024
@fabxoe @chhaewxn @NielsRogge
🌐 [i18n-KO] Translated model_doc/deberta-v2.md to Korean (huggingfa…
ba3951e 
…ce#33968)

* docs: ko: model_doc/deberta-v2.md

* feat: nmt draft

* fix: resolve suggestions

Co-authored-by: Chaewon Song <chaewon1019@ewhain.net>

* fix: resolve suggestions

* fix: resolve suggestions

---------

Co-authored-by: Chaewon Song <chaewon1019@ewhain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chhaewxn chhaewxn chhaewxn left review comments

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabxoe @HuggingFaceDocBuilderDev @stevhliu @chhaewxn