Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #34314

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Drop support for Python 3.8 #34314

merged 2 commits into from
Oct 24, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 22, 2024

What does this PR do?

Python 3.8 reached EOL on Oct. 07, 2024

https://devguide.python.org/versions/

@ydshieh ydshieh requested a review from ArthurZucker October 22, 2024 14:34
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG finally!

@ydshieh
Copy link
Collaborator Author

ydshieh commented Oct 22, 2024

I will merge once I am able to build the images with python 3.9

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ydshieh ydshieh merged commit f0e640a into main Oct 24, 2024
20 of 25 checks passed
@ydshieh ydshieh deleted the drop_py38 branch October 24, 2024 09:16
frances720 pushed a commit to Promptless/transformers-test that referenced this pull request Nov 8, 2024
* drop python 3.8

* update docker files

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* drop python 3.8

* update docker files

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants