Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Past Keys Output now working with output router logits #34707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

csking101
Copy link

What does this PR do?

This handles the case where output_router_logits are True, and past key values are being used for inference, in the Mistral model.

Fixes #30731

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Sorry but this seems to be a little bit too complicated for a fix that should be simpler! 🤗

@csking101
Copy link
Author

Hi @ArthurZucker , could you give me a pointer as to how to go about it, as I think I confused myself with the approach. The main reason why I did this was, because I was unsure about what to do with the missing attention for the previous outputs, when running the model in inference mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixtral past_key_values and output_router_logits incompatible
2 participants