Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failling GGML test #34871

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix failling GGML test #34871

merged 1 commit into from
Nov 25, 2024

Conversation

MekkCyber
Copy link
Contributor

What does this PR do?

This PR fixes a failling test in test_ggml.py related to the function test_falcon7b_q2_k. The error that was occuring is

The following `model_kwargs` are not used by the model: ['token_type_ids'] (note: typos in the generate arguments will also show up in this list)

Who can review ?

@SunMarc

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Even if a kwargs was not used, it is not a reason to raise an error. I'm not sure why we have this kind of behavior from generate, especially when we are just passing the output from the tokenizer.

@SunMarc SunMarc merged commit 890ea7d into main Nov 25, 2024
12 checks passed
@SunMarc SunMarc deleted the fix_ggml_test branch November 25, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants