Fix model_accepts_loss_kwargs
for timm model
#35257
Merged
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TimmWrapper
model training is broken due to thenum_items_in_batch
param passed to the model forward.TimmWrapper
model has**kwargs
in thetransformers
model forward, but it goes straight to thetimm
model and not to the loss. This PR introduces a fix to avoid passing loss_kwargs even if**kwargs
are in model forward.Relevant to:
trainer
] fix the GAmodel_accepts_loss_kwargs
#34915cc @ArthurZucker