-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated/unused dependencies 🧹 🧹 #36419
base: main
Are you sure you want to change the base?
Changes from 1 commit
9a91792
01ee980
a768ee1
2ac1bcc
a6d69d9
016ecb5
b0fb446
38e7719
6a10e69
f969855
a0d333a
de877b2
ffcaaba
5a70632
6573230
c92ffce
ad2ff65
af7b882
ef88ff5
1b03012
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,33 +69,14 @@ | |
|
||
import os | ||
import re | ||
import shutil | ||
from pathlib import Path | ||
|
||
from setuptools import Command, find_packages, setup | ||
|
||
|
||
# Remove stale transformers.egg-info directory to avoid https://github.com/pypa/pip/issues/5466 | ||
stale_egg_info = Path(__file__).parent / "transformers.egg-info" | ||
if stale_egg_info.exists(): | ||
print( | ||
( | ||
"Warning: {} exists.\n\n" | ||
"If you recently updated transformers to 3.0 or later, this is expected,\n" | ||
"but it may prevent transformers from installing in editable mode.\n\n" | ||
"This directory is automatically generated by Python's packaging tools.\n" | ||
"I will remove it now.\n\n" | ||
"See https://github.com/pypa/pip/issues/5466 for details.\n" | ||
).format(stale_egg_info) | ||
) | ||
shutil.rmtree(stale_egg_info) | ||
|
||
|
||
# IMPORTANT: | ||
# 1. all dependencies should be listed here with their version requirements if any | ||
# 2. once modified, run: `make deps_table_update` to update src/transformers/dependency_versions_table.py | ||
_deps = [ | ||
"Pillow>=10.0.1,<=15.0", | ||
gante marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"accelerate>=0.26.0", | ||
"av", | ||
"beautifulsoup4", | ||
|
@@ -144,6 +125,7 @@ | |
"packaging>=20.0", | ||
"parameterized", | ||
"phonemizer", | ||
"Pillow>=10.0.1,<=15.0", | ||
"protobuf", | ||
"psutil", | ||
"pyyaml>=5.1", | ||
|
@@ -345,6 +327,7 @@ def run(self): | |
) | ||
+ extras["retrieval"] | ||
+ extras["modelcreation"] | ||
+ extras["tiktoken"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. needed to test Some of our CI images rely on installing |
||
) | ||
|
||
extras["deepspeed-testing"] = extras["deepspeed"] + extras["testing"] + extras["optuna"] + extras["sentencepiece"] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -839,13 +839,13 @@ def test_special_tokens_strip(self): | |
self.assertEqual(tokens, ["▁No", "<s>", "▁He"]) # spaces are eaten by rstrip / lstrip | ||
|
||
|
||
@require_tiktoken | ||
@require_read_token | ||
class TikTokenIntegrationTests(unittest.TestCase): | ||
""" | ||
A class that regroups important test to make sure that we properly handle the special tokens. | ||
""" | ||
|
||
@require_tiktoken | ||
@require_read_token | ||
Comment on lines
+847
to
+848
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
def test_tiktoken_llama(self): | ||
model_path = "hf-internal-testing/llama-3-8b-internal" | ||
subfolder = "original" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root issue was sorted and added to pip 20.1, released in early 2020. Our minimum python version is 3.9, released in late 2020, and it comes with a pip version more recent than 20.1.