Skip to content

Conversation

@alex-jw-brooks
Copy link
Contributor

This PR exposes Blip2QFormer so that it can be created via AutoModel.from_config, which is needed for making the projector component in granite speech generic (discussed in this PR).

Blip2QFormer is most of the way there already - this PR just:

  • Handles AutoModel registration
  • Adds docstrings / more information on forward inputs

Note that Blip2QFormer is already tested pretty extensively though the blip2 tests, and will also be tested through granite speech tests.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker can you please take a look?

@github-actions github-actions bot marked this pull request as draft April 3, 2025 16:19
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@alex-jw-brooks alex-jw-brooks marked this pull request as ready for review April 3, 2025 16:21
Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it auto-mappable, looks good to me!

@alex-jw-brooks
Copy link
Contributor Author

Awesome, thank you for the quick review @zucchini-nlp! I went ahead and rebased this pr to fix the conflict 🙂

@zucchini-nlp
Copy link
Member

Thanks, we can merge when CI turns green

@zucchini-nlp zucchini-nlp merged commit 2515a5a into huggingface:main Apr 8, 2025
18 checks passed
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
* Expose blip2qformer

* Add missing args to blip2 config
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* Expose blip2qformer

* Add missing args to blip2 config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants