Skip to content

Conversation

@zucchini-nlp
Copy link
Member

@zucchini-nlp zucchini-nlp commented Apr 15, 2025

What does this PR do?

Fixes #37513 and fixes #37515. Ready for review!

@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft April 15, 2025 08:03
@zucchini-nlp zucchini-nlp marked this pull request as ready for review April 15, 2025 08:03
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp
Copy link
Member Author

Should be ready for review now, doesn't seem we have any other issues reported with qwen training

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, but modular needs to be reapplied here 😁

@zucchini-nlp zucchini-nlp merged commit dcf6df5 into huggingface:main Apr 22, 2025
14 checks passed
@hmellor hmellor added the for patch Tag issues / labels that should be included in the next patch label Apr 24, 2025
zucchini-nlp added a commit to zucchini-nlp/transformers that referenced this pull request May 14, 2025
* fix

* add text config

* fixup

* fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for patch Tag issues / labels that should be included in the next patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'Qwen2_5OmniConfig' object has no attribute 'num_attention_heads' Qwen2_5Omni training forward issue

4 participants