-
Notifications
You must be signed in to change notification settings - Fork 31k
[Falcon H1] Fix slow path forward pass #38320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Checking in with the slow tests :)
|
run-slow: falcon_h1 cc @ydshieh anything I should do differently? |
|
@vasqu It's triggered, but failed at a step (reply to comment) and the tests are not run. https://github.com/huggingface/transformers/actions/runs/15250152202/job/42884998108 I'm not sure why, but I will re-run it and see how it goes. |
|
This comment contains run-slow, running the specified jobs: models: ['models/falcon_h1'] |
1 similar comment
|
This comment contains run-slow, running the specified jobs: models: ['models/falcon_h1'] |
|
Slow tests failed, but not sure if this PR caused the failure since we only changed the slow path which is not executed on GPUs, perhaps they failed since the beginning? |
|
We're not able to extract the expected text from the logs and we don't have access to T4 GPUs.. is there a way to extract the output from the logs? |
|
I can update the expected value this afternoon |
|
i pushed a fix in the Integration test |
|
run-slow: falcon_h1 |
|
This comment contains run-slow, running the specified jobs: models: ['models/falcon_h1'] |
@younesbelkada you don't love @ydshieh anymore ? You owe me instructblip .... |
|
ahaha sorry let me give you access now ! yes I owe you that one ... which took so long to fix together |
|
The updated value works for T4. No more need to run-slow Thank you for the effort 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤗
|
Thank you very much @ydshieh and HF team for your continuous support ! 🚀 |
|
wait don't merge yet. I will check again and merge once ok |
|
Thanks all guys for your help |
* update * update --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This PR:
torch_forwardrepeat->repeat_interleavesee Fix Mamba2 Grouped SSD Support in the torch_forward Path #37533@ArthurZucker